fix: negative trace substraction when using SetTimeout #1038
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeevatkm
requested changes
Nov 8, 2025
Member
jeevatkm
left a comment
jeevatkm
left a comment
There was a problem hiding this comment.
@nicolasbeauvais Thanks for the PR. I'm sorry for the delayed response, I was occupied with my personal stuff.
I added a one review comment.
jeevatkm
changed the title
Member
|
Also, the same issue might exist in the v2 too. I will backport it afterwards, or you can also submit PR v2 if you're interested. |
Author
|
Hey @jeevatkm, no worries, I hope you're doing good! I've set the default value directly at object initialization, let me know if that's ok for you. I can make a PR on the v2 branch once this one is approved. |
jeevatkm
approved these changes
Nov 15, 2025
Member
jeevatkm
left a comment
jeevatkm
left a comment
There was a problem hiding this comment.
@nicolasbeauvais Thanks for updating PR.
Member
|
@nicolasbeauvais It seems this test case having an issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In certain cases when using client or request SetTimeout it is possible that some trace value like
dnsDone,tlsHandshakeDoneorgotConnare zero, resulting in inaccurate results:This PR add additional checks in the
TraceInfomethod to avoid negative values.I'm not sure how to improve the tests for this, as aborting requests with SetTimeout will not always accurately stop the execution at the exact same point. I'm open to ideas.